Remove deprecation diagnostic supppression for dtostrf #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #212 +/- ##
==========================================
- Coverage 95.52% 95.50% -0.03%
==========================================
Files 16 15 -1
Lines 1072 1067 -5
==========================================
- Hits 1024 1019 -5
Misses 48 48 ☔ View full report in Codecov by Sentry. |
|
I'm not a maintainer. This is just a fly-by comment. Isn't this https://en.cppreference.com/w/cpp/string/basic_string/to_string.html Adding new names for things that have been in the standard library for years just splits developer mindshare and increases maintenance burden. to_chars, unlike the warning in the code here, doesn't have the risk of buffer overruns. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have the tests use an implementation of
dtostrfwhich checks for the largest buffer needed by the String class.Document the risks of that implementaton and add a TODO not to rely on this function in the production code.
As this no longer uses the deprecated sample implementation, the warning suppression can be removed as it is not compiled.